-
-
Notifications
You must be signed in to change notification settings - Fork 177
Add (partial) safe protocol implementation for EFI_HII_DATABASE_PROTOCOL #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
144e2a9
to
917c7a0
Compare
This is one of the last things we (IP-Projects) need ... for now. Though I'm somewhat at a loss as to how to continue with this. Would it be acceptable to add a new dependency on something like binrw to add this to uefi-rs, or do you regard hiidb parsing as out-of-scope for uefi-rs alltogether? |
Not sure, we haven't done this so far. I have a light tendency towards no. In the documentation of the corresponding "high level" abstraction in |
e721b59
to
eb3bfe1
Compare
c62f6ac
to
2d4c7c8
Compare
The HII data isn't something I'm very familiar with, so I don't have a strong opinion yet on adding a dep like binrw. I'd suggest as a first step, to try writing some representative code so that we can see what it looks like and put up an example PR. Feel free to use binrw or whatever other deps. Then we can evaluate how best to approach it. For example, we could decide to add it as an optional dep, so that it's only used when a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I rebased to fix the changelog conflict.
This only grants access to the HII-database's raw buffer for now.
2d4c7c8
to
440e84c
Compare
This only grants access to the HII-database's raw buffer for now.
Checklist